-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to Egamma/Electrons plots: separate +/- endcap for alignment,… #9050
Changes to Egamma/Electrons plots: separate +/- endcap for alignment,… #9050
Conversation
… add sieie and PFiso
A new Pull Request was created by @gzevi for CMSSW_7_4_X. Changes to Egamma/Electrons plots: separate +/- endcap for alignment, It involves the following packages: DQMOffline/EGamma @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
The usual DQM tests (python whiteRabbit.py -j4 -n1,2,11,12) work in CMSSW_7_4_X_2015-05-11-2300, but they fail in CMSSW_7_4_X, even without this commit. |
@gzevi That error usually means you have an inconsistent build area. Have you done a |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@davidlange6, could we ask for your signature here, if you approve the changes? |
+1 |
Changes to Egamma/Electrons plots: separate +/- endcap for alignment,…
Backport of PR #9010
Comment from PR #9010:
DQMOffline plots for Egamma/Electrons are a bit out of date.
Starting here with some small fixes: add SigmaIetaIeta5x5 plots and PFIsolation plots (based on variables used in electron ID). Also separating positive and negative endcaps for alignment sensitive plots such as DeltaEta and DeltaPhi between track and supercluster.