Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Egamma/Electrons plots: separate +/- endcap for alignment,… #9050

Merged
merged 1 commit into from
Jun 5, 2015

Conversation

gzevi
Copy link
Contributor

@gzevi gzevi commented May 12, 2015

Backport of PR #9010

Comment from PR #9010:
DQMOffline plots for Egamma/Electrons are a bit out of date.
Starting here with some small fixes: add SigmaIetaIeta5x5 plots and PFIsolation plots (based on variables used in electron ID). Also separating positive and negative endcaps for alignment sensitive plots such as DeltaEta and DeltaPhi between track and supercluster.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gzevi for CMSSW_7_4_X.

Changes to Egamma/Electrons plots: separate +/- endcap for alignment,

It involves the following packages:

DQMOffline/EGamma

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@gzevi
Copy link
Contributor Author

gzevi commented May 12, 2015

The usual DQM tests (python whiteRabbit.py -j4 -n1,2,11,12) work in CMSSW_7_4_X_2015-05-11-2300, but they fail in CMSSW_7_4_X, even without this commit.
Error looks like:
-bash-4.1$ more 1431440645/11/p11.1.log
Conditions read from CMS_CONDITIONS via FrontierProd
DQMStore: verbosity set to 2
DQMStore: QTest verbosity set to 0
DQMStore: Scaling Flag set to 0
----- Begin Fatal Exception 12-May-2015 16:24:36 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
[0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/work/g/gzevi/EGM/Commissioning/Fresh/Test2/CMSSW_7_4_X_2015-05-11-2300/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-MagneticFieldParametrizedEngin
ePlugins.so because /afs/cern.ch/work/g/gzevi/EGM/Commissioning/Fresh/Test2/CMSSW_7_4_X_2015-05-11-2300/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-MagneticFieldParametrized
EnginePlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

@Dr15Jones
Copy link
Contributor

@gzevi That error usually means you have an inconsistent build area. Have you done a git cms-checkdeps -a ?

@deguio
Copy link
Contributor

deguio commented May 12, 2015

please test

@deguio
Copy link
Contributor

deguio commented May 12, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9050/4646/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@gzevi
Copy link
Contributor Author

gzevi commented Jun 3, 2015

@davidlange6, could we ask for your signature here, if you approve the changes?
These DQM Offline plots would be helpful for electron commissioning, and I realized today (looking at stable beams) that they had not yet been merged.
Thank you!

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants